Skip to content

Comments

refactor: remove deprecations in HTTP [WIP]#10000

Draft
paulbalandan wants to merge 1 commit intocodeigniter4:4.8from
paulbalandan:cleanup-http
Draft

refactor: remove deprecations in HTTP [WIP]#10000
paulbalandan wants to merge 1 commit intocodeigniter4:4.8from
paulbalandan:cleanup-http

Conversation

@paulbalandan
Copy link
Member

Description
Sending this early to get the #10000 slot. 😂

This is not yet complete, but initially there are quite breaking changes:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities docs needed Pull requests needing documentation write-ups and/or revisions. 4.8 PRs that target the `4.8` branch. labels Feb 24, 2026
@paulbalandan paulbalandan marked this pull request as draft February 24, 2026 15:50
@michalsn
Copy link
Member

Sending this early to get the #10000 slot. 😂

Haha, love the dedication 😆

I'm a little concerned about removing URI::setSilent(). Given how commonly it's used, this might be more disruptive than expected.

@paulbalandan
Copy link
Member Author

I'm a little concerned about removing URI::setSilent(). Given how commonly it's used, this might be more disruptive than expected.

The deprecation was made in #7252 , mainly because it's not in PSR-7. Do you mean to "un-deprecate" it?

@michalsn
Copy link
Member

Well, the reason in the comment ("Method not in PSR-7") isn't very fortunate, because PSR-7 allows extra methods.

The real problem is immutability and hidden behavioral state.

Since setSilent() has existed for a long time and occasionally comes up on Slack, I would prefer postponing removal until v5 to avoid unnecessary complaints.

@paulbalandan
Copy link
Member Author

Okay, I'll retain it and add a hard deprecation notice on it. For the *Silent tests, are you fine with removing them though?

@michalsn
Copy link
Member

Yes, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.8 PRs that target the `4.8` branch. breaking change Pull requests that may break existing functionalities docs needed Pull requests needing documentation write-ups and/or revisions. refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants